Fixes incorrectly applied .forEach #2554
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.forEach` was incorrectly made available to all DOM Iterators in core-js. This has now been fixed in the package: zloirock/core-js#988 The recommended approach for HTMLCollections objects is to use `Array.from` (https://developer.mozilla.org/en-US/docs/Web/API/HTMLCollection). This has been applied to the code to support the `.forEach` function. This was originally noticed when updating the yarn.lock file in PR #2551. Credits: @ollietreend for finding the solution.
kevindew
reviewed
Jul 27, 2022
| @@ -36,7 +36,7 @@ window.GOVUK.Modules = window.GOVUK.Modules || {}; | |||
| id: $select.id, | |||
| source: function (query, syncResults) { | |||
| var results = [] | |||
| $select.options.forEach(function ($el) { | |||
| Array.from($select.options).forEach(function ($el) { | |||
There was a problem hiding this comment.
Array.from is a method that's not in IE. Do we get this polyfilled by core JS?
Could also use the boring old for (var i .. ?
There was a problem hiding this comment.
D'oh! 🙈 Good spot @kevindew.
This should do the trick then:
var $el
for (var i = 0; i < $select.options.length; i++) {
$el = $select.options[i]
console.log($el)
}There was a problem hiding this comment.
Looks like core js polyfills it: https://github.com/zloirock/core-js/blob/master/packages/core-js/modules/es.array.from.js
There was a problem hiding this comment.
Didn't have any contacts locally but Array.from() seems to work on IE11
|
Great stuff 👍 Always fun when we actually get to use other enumerators than the basic for loop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.forEachwas incorrectly made available to all DOM Iterators in core-js. This has now been fixed in the package: zloirock/core-js#988The recommended approach for HTMLCollections objects is to use
Array.from(https://developer.mozilla.org/en-US/docs/Web/API/HTMLCollection). This has been applied to the code to support the.forEachfunction.This was originally noticed when updating the yarn.lock file in PR #2551.
Credits: @ollietreend for finding the solution.