[WIP] [DO NOT MERGE] Redesign No. 10 organisation page #3605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andysellick
reviewed
May 14, 2024
- add test for missing image reporting - move promotional features around to match promotional features with video details - add stubs for missing news items to test handling of unusual cases on integration
- Split promotional features methods into their own helper - Add styles for videos partials links - Videos partial - Add the video title as a heading - Use brand color for more videos link - Use YouTube video URL as the YouTube link text To prevent duplication with the heading above it in no-js situations. - Tests for helper
- Helper that grabs latest news from a search - Also grabs content item for first latest news item to get image - Partial for latest news - Add default image fallback (No. 10 front door, since this is only used by No. 10 at the moment) - tests for helper
- partial for small feature news items - partial for side-by-side prmotional features
andysellick
approved these changes
May 23, 2024
andysellick
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Things for frontend to look at:
The image card is alwayslarge: truewhen a YouTube video is present, causing a formatting issue, so component change is neededThings for backend to look at:
app/presenters/organisations/contacts_presenter.rbline 68 (basically you need to remove brand__color if its the no 10 page) and I can't figure out how to do it as the@org.is_no_10?boolean doesn't work in that presenter@what_we_do.has_share_links?, so maybe they can't remove the 'what we do' section from Whitehall?