This repository has been archived by the owner on May 15, 2024. It is now read-only.
BR-1821 Prevent wp_unslash from breaking escaped chars in data or metadata #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevinfodness FWIW I think the only reason I had |
meddy
approved these changes
Dec 13, 2017
|
@meddy unfortunately i don't think so, that issue had more to do with how the subtitle field is stored kinda separately from the rest of the metadata |
kevinfodness
approved these changes
Dec 13, 2017
| @@ -93,7 +93,7 @@ protected function _do_save_post( $post ) { | |||
| foreach ( array( 'chartData', 'chartOptions', 'chartMetadata', 'googleSheetId' ) as $field ) { | |||
| if ( ! empty( $_POST[ 'save-' . $field ] ) ) { | |||
| // sanitize field name w/ esc_attr() instead of sanitize_key() because we want to preserve uppercase letters | |||
| update_post_meta( $post->ID, 'save-' . esc_attr( $field ), sanitize_text_field( wp_unslash( $_POST[ 'save-' . $field ] ) ) ); | |||
| update_post_meta( $post->ID, 'save-' . esc_attr( $field ), sanitize_text_field( $_POST[ 'save-' . $field ] ) ); | |||
There was a problem hiding this comment.
You're going to need to tell WPCS to ignore the wp_unslash rule here. There is an open issue about false positives for this sniff with functions that expect slashed data, of which update_post_meta is one:
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, with
wp_unslash():After, without
wp_unslash()