Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use @InputFile on RepositoryConfig#getCustomKeyFile #560

Merged
merged 1 commit into from Nov 28, 2022

Conversation

jcgay
Copy link
Contributor

@jcgay jcgay commented Nov 28, 2022

Gradle displays this message (without failing) with version 7.6:

> Task :currentVersion
Execution optimizations have been disabled for task ':currentVersion' to ensure correctness due to the following reasons:
  - In plugin 'pl.allegro.tech.build.axion.release.ReleasePlugin$Inject' type 'pl.allegro.tech.build.axion.release.OutputCurrentVersionTask' property 'versionConfig.repository.customKeyFile' has @Input annotation used on property of type 'RegularFileProperty'. Reason: A property of type 'RegularFileProperty' annotated with @Input cannot determine how to interpret the file. Please refer to https://docs.gradle.org/7.6/userguide/validation_problems.html#incorrect_use_of_input_annotation for more details about this problem.

Fixes #559

Gradle displays this message (without failing) with version 7.6:

    > Task :currentVersion
    Execution optimizations have been disabled for task ':currentVersion' to ensure correctness due to the following reasons:
      - In plugin 'pl.allegro.tech.build.axion.release.ReleasePlugin$Inject' type 'pl.allegro.tech.build.axion.release.OutputCurrentVersionTask' property 'versionConfig.repository.customKeyFile' has @input annotation used on property of type 'RegularFileProperty'. Reason: A property of type 'RegularFileProperty' annotated with @input cannot determine how to interpret the file. Please refer to https://docs.gradle.org/7.6/userguide/validation_problems.html#incorrect_use_of_input_annotation for more details about this problem.

Fixes allegro#559
@jcgay
Copy link
Contributor Author

jcgay commented Nov 28, 2022

I have not added any test. I could test the output for the offending message but does it makes sense ? 😇
Or let me know if you have some in the integration test suite that should be updated :)

@codecov-commenter
Copy link

Codecov Report

Merging #560 (0320388) into main (c73b032) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #560   +/-   ##
=========================================
  Coverage     61.03%   61.03%           
  Complexity      384      384           
=========================================
  Files            81       81           
  Lines          1504     1504           
  Branches        141      141           
=========================================
  Hits            918      918           
  Misses          521      521           
  Partials         65       65           
Impacted Files Coverage Δ
...build/axion/release/domain/RepositoryConfig.groovy 93.33% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@bgalek
Copy link
Collaborator

bgalek commented Nov 28, 2022

@jcgay LGTM! Thx!

@bgalek bgalek merged commit e628e66 into allegro:main Nov 28, 2022
@jcgay jcgay deleted the inputfile branch November 28, 2022 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Execution optimizations disabled message with Gradle 7.6
3 participants