Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[risk=low][no ticket] rev async to 2.6.4 #6568

Merged
merged 1 commit into from Apr 14, 2022
Merged

[risk=low][no ticket] rev async to 2.6.4 #6568

merged 1 commit into from Apr 14, 2022

Conversation

jmthibault79
Copy link
Collaborator

@jmthibault79 jmthibault79 commented Apr 14, 2022 •
edited

Addresses a vulnerability: https://github.com/all-of-us/workbench/security/dependabot/25
caolan/async#1828

Ran local UI against Test with no problems.

PR checklist

  • This PR meets the Acceptance Criteria in the JIRA story
  • The JIRA story has been moved to Dev Review
  • This PR includes appropriate unit tests
  • I have added explanatory comments where the logic is not obvious
  • I have run and tested this change locally, and my testing process is described here
  • If this includes a new feature flag, I have created and linked new JIRA tickets to (a) turn on the feature flag and (b) remove it later
  • If this includes an API change, I have run the E2E tests on this change against my local server with yarn test-local because this PR won't be covered by the CircleCI tests
  • If this includes a UI change, I have taken screen recordings or screenshots of the new behavior and notified the PO and UX designer in Slack
  • If this change impacts deployment safety (e.g. removing/altering APIs which are in use) I have documented these in the description
  • If this includes an API change, I have updated the appropriate Swagger definitions and updated the appropriate API consumers

@jmthibault79 jmthibault79 merged commit 46977f5 into main Apr 14, 2022
@jmthibault79 jmthibault79 deleted the joel/bump-async branch April 14, 2022 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dolbeew dolbeew dolbeew approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmthibault79 @dolbeew