Commits on Apr 9, 2024

1. Add github action cache for redis-server binary …

   ${MAKE} -C integration redis_src/redis-server that is part of ci target
   takes around 2 minutes to execute. With addition of cache preventing
   rebuild of redis-server tests run time drops from ~2m50s to ~50s.
   
   Currently github actions are free for public repositories[1] but I think
   that shorter execution time will improve developer experience :)
   
   Due to matrix build for go versions, when redis is upgraded, build will be
   run multiple times in parallel. Unnecessary parallel builds can be
   avoided but since we don't upgrade redis too often I feel it would be
   unnecessary complication.
   
   Perhaps even better solution might be usage of testcontainers[2].
   Integration tests would basically download and run official redis docker
   image and spin it up for tests. There would be no need for cache or building
   binary but docker dependency would be introduced. I have decided to
   introduce cache because docker dependency has pros and cons that need to
   be discussed while cache is clear and easy win ;)
   
   PR: alicebob#372
   [1]: https://docs.github.com/en/actions/learn-github-actions/usage-limits-billing-and-administration
   [2]: https://golang.testcontainers.org/
   
   Signed-off-by: Wojciech Szarański <wojciech.szaranski@gmail.com>

   

   wszaranski committed Apr 9, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for be85aa3
   • Browse repository at this point

   Copy the full SHA

   be85aa3 View commit details

   Browse the repository at this point in the history