Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integer overflow #361

Merged
merged 1 commit into from Mar 23, 2024
Merged

Conversation

wszaranski
Copy link
Contributor

@wszaranski wszaranski commented Mar 15, 2024

Fixes INCR, DECR, INCRBY, DECRBY to return error when value would overflow.

Closes: #291

Fixes INCR, DECR, INCRBY, DECRBY to return error when value would
overflow.

Closes: alicebob#291

Signed-off-by: Wojciech Szarański <wojciech.szaranski@gmail.com>
@wszaranski wszaranski marked this pull request as ready for review March 15, 2024 13:12
@alicebob
Copy link
Owner

Interesting, thanks! Looks great, but will have a proper look soon.

@alicebob
Copy link
Owner

Didn't get around to this yet, not forgotten!, probably this weekend.

@alicebob alicebob merged commit 6b28640 into alicebob:master Mar 23, 2024
4 checks passed
@alicebob
Copy link
Owner

thanks!

@wszaranski wszaranski deleted the fix-integer-overflow branch April 9, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem about overflow inspection of INCRBY/DECRBY
2 participants