Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #10323] fix remove wrong keys when healthy list changed #12099

Closed
wants to merge 1 commit into from

Conversation

BlackBAKA
Copy link
Contributor

@BlackBAKA BlackBAKA commented May 15, 2024

Please do not create a Pull Request without creating an issue first.

What is the purpose of the change

fix #10323

Brief changelog

XX

Verifying this change

XXXX

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
  • Format the pull request title like [ISSUE #123] Fix UnknownException when host config not exist. Each commit in the pull request should have a meaningful subject line and body.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in test module.
  • Run mvn -B clean package apache-rat:check findbugs:findbugs -Dmaven.test.skip=true to make sure basic checks pass. Run mvn clean install -DskipITs to make sure unit-test pass. Run mvn clean test-compile failsafe:integration-test to make sure integration-test pass.

@CLAassistant
Copy link

CLAassistant commented May 15, 2024

CLA assistant check
All committers have signed the CLA.

@shalk
Copy link
Contributor

shalk commented May 15, 2024

I looks like a risk change.
Would better to give a poc test to proof it.

@KomachiSion
Copy link
Collaborator

没看懂这个方案的逻辑,如果健康列表变了,就应该把变更的内容都同步下去, 发现不一致,还要把已经移除的节点保留,数据一致性问题应该会更大。

@KomachiSion KomachiSion added pending On hold due to dependency or release kind/discussion Category issues related to discussion labels May 16, 2024
@BlackBAKA BlackBAKA closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Category issues related to discussion pending On hold due to dependency or release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants