feat(useGetState): get state synchronously #2268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liuyib
commented
Jul 27, 2023
|
@li-jia-nan @hchlq @miracles1919 @crazylxr pls review |
hchlq
reviewed
Aug 7, 2023
| const setState = useCallback<SetStateAction<S | undefined>>((stateOrAction) => { | ||
| const newState = isFunction(stateOrAction) ? stateOrAction(stateRef.current) : stateOrAction; | ||
|
|
||
| stateRef.current = newState; |
There was a problem hiding this comment.
程哥，看下这个讨论：#2266 (comment), 这个 PR 的改动， 之前就有人提过 #1306 (comment), 不知道现在这个改动算不算破坏性更改呢？之前是没法通过 getState 同步获取到最新状态的， 应该不会有人还用它来获取旧状态吧 #2266 (comment)
There was a problem hiding this comment.
有可能的，刚才有想到过，不过一般使用的人都是在 render 过程中的，像在 set 之后重新获取旧状态的比较少。
不过咱们还是保险起见，放到 v4 的规划是不是更好呢
There was a problem hiding this comment.
有可能的，刚才有想到过，不过一般使用的人都是在 render 过程中的，像在 set 之后重新获取旧状态的比较少。
不过咱们还是保险起见，放到 v4 的规划是不是更好呢
好的呢，那就放在 v4 做吧~
|
建议新增 hook，以免引入 breaking changes，新 hook：#2348 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
resolve: #2266
💡 Background and solution
📝 Changelog
☑️ Self Check before Merge