Upgrade to Istio 1.19.0 and implement Gateway API support #717

CH3CHO · 2023-12-20T05:12:46Z

Ⅰ. Describe what this PR did

Upgrade to Istio 1.19.0 and implement Gateway API support.

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Conflicts will be fixed later.

…nfigs to xDS resources

codecov-commenter · 2024-01-08T08:18:05Z

Codecov Report

Attention: 979 lines in your changes are missing coverage. Please review.

Comparison is base (90f89cf) 38.14% compared to head (e29820f) 47.36%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #717      +/-   ##
==========================================
+ Coverage   38.14%   47.36%   +9.21%     
==========================================
  Files          61       56       -5     
  Lines       10342    10358      +16     
==========================================
+ Hits         3945     4906     +961     
+ Misses       6098     5155     -943     
+ Partials      299      297       -2

Files	Coverage Δ
pkg/cmd/server.go	`84.81% <100.00%> (+0.59%)`	⬆️
pkg/ingress/kube/annotations/annotations.go	`31.63% <ø> (ø)`
pkg/ingress/kube/annotations/canary.go	`53.63% <100.00%> (+0.79%)`	⬆️
pkg/ingress/kube/annotations/cors.go	`88.46% <100.00%> (ø)`
pkg/ingress/kube/annotations/default_backend.go	`69.64% <ø> (-10.36%)`	⬇️
pkg/ingress/kube/annotations/downstreamtls.go	`88.23% <100.00%> (ø)`
pkg/ingress/kube/annotations/ip_access_control.go	`0.00% <ø> (-87.50%)`	⬇️
pkg/ingress/kube/annotations/loadbalance.go	`87.39% <100.00%> (ø)`
pkg/ingress/kube/annotations/local_rate_limit.go	`100.00% <ø> (ø)`
pkg/ingress/kube/annotations/retry.go	`100.00% <100.00%> (ø)`
... and 32 more

... and 15 files with indirect coverage changes

github-actions

license-eye has totally checked 946 files.

Valid	Invalid	Ignored	Fixed
386	32	528	0

Click to see the invalid file list

hgctl/cmd/hgctl/config/testdata/config/input/in.all.json
hgctl/cmd/hgctl/config/testdata/config/output/out.all.json
hgctl/cmd/hgctl/config/testdata/config/output/out.all.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.bootstrap.json
hgctl/cmd/hgctl/config/testdata/config/output/out.bootstrap.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.cluster.json
hgctl/cmd/hgctl/config/testdata/config/output/out.cluster.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.endpoints.json
hgctl/cmd/hgctl/config/testdata/config/output/out.endpoints.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.listener.json
hgctl/cmd/hgctl/config/testdata/config/output/out.listener.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.route.json
hgctl/cmd/hgctl/config/testdata/config/output/out.route.yaml
hgctl/pkg/manifests/istiobase/Chart.yaml
hgctl/pkg/manifests/istiobase/README.md
hgctl/pkg/manifests/istiobase/crds/crd-all.gen.yaml
hgctl/pkg/manifests/istiobase/crds/crd-operator.yaml
hgctl/pkg/manifests/istiobase/templates/clusterrole.yaml
hgctl/pkg/manifests/istiobase/templates/clusterrolebinding.yaml
hgctl/pkg/manifests/istiobase/templates/crds.yaml
hgctl/pkg/manifests/istiobase/templates/default.yaml
hgctl/pkg/manifests/istiobase/templates/endpoints.yaml
hgctl/pkg/manifests/istiobase/templates/reader-serviceaccount.yaml
hgctl/pkg/manifests/istiobase/templates/role.yaml
hgctl/pkg/manifests/istiobase/templates/rolebinding.yaml
hgctl/pkg/manifests/istiobase/templates/serviceaccount.yaml
hgctl/pkg/manifests/istiobase/templates/services.yaml
hgctl/pkg/manifests/istiobase/values.yaml
hgctl/pkg/manifests/profiles/_all.yaml
hgctl/pkg/manifests/profiles/k8s.yaml
hgctl/pkg/manifests/profiles/local-docker.yaml
hgctl/pkg/manifests/profiles/local-k8s.yaml

github-actions

license-eye has totally checked 964 files.

Valid	Invalid	Ignored	Fixed
391	32	541	0

Click to see the invalid file list

hgctl/cmd/hgctl/config/testdata/config/input/in.all.json
hgctl/cmd/hgctl/config/testdata/config/output/out.all.json
hgctl/cmd/hgctl/config/testdata/config/output/out.all.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.bootstrap.json
hgctl/cmd/hgctl/config/testdata/config/output/out.bootstrap.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.cluster.json
hgctl/cmd/hgctl/config/testdata/config/output/out.cluster.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.endpoints.json
hgctl/cmd/hgctl/config/testdata/config/output/out.endpoints.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.listener.json
hgctl/cmd/hgctl/config/testdata/config/output/out.listener.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.route.json
hgctl/cmd/hgctl/config/testdata/config/output/out.route.yaml
hgctl/pkg/manifests/istiobase/Chart.yaml
hgctl/pkg/manifests/istiobase/README.md
hgctl/pkg/manifests/istiobase/crds/crd-all.gen.yaml
hgctl/pkg/manifests/istiobase/crds/crd-operator.yaml
hgctl/pkg/manifests/istiobase/templates/clusterrole.yaml
hgctl/pkg/manifests/istiobase/templates/clusterrolebinding.yaml
hgctl/pkg/manifests/istiobase/templates/crds.yaml
hgctl/pkg/manifests/istiobase/templates/default.yaml
hgctl/pkg/manifests/istiobase/templates/endpoints.yaml
hgctl/pkg/manifests/istiobase/templates/reader-serviceaccount.yaml
hgctl/pkg/manifests/istiobase/templates/role.yaml
hgctl/pkg/manifests/istiobase/templates/rolebinding.yaml
hgctl/pkg/manifests/istiobase/templates/serviceaccount.yaml
hgctl/pkg/manifests/istiobase/templates/services.yaml
hgctl/pkg/manifests/istiobase/values.yaml
hgctl/pkg/manifests/profiles/_all.yaml
hgctl/pkg/manifests/profiles/k8s.yaml
hgctl/pkg/manifests/profiles/local-docker.yaml
hgctl/pkg/manifests/profiles/local-k8s.yaml

github-actions

license-eye has totally checked 964 files.

Valid	Invalid	Ignored	Fixed
391	32	541	0

Click to see the invalid file list

hgctl/cmd/hgctl/config/testdata/config/input/in.all.json
hgctl/cmd/hgctl/config/testdata/config/output/out.all.json
hgctl/cmd/hgctl/config/testdata/config/output/out.all.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.bootstrap.json
hgctl/cmd/hgctl/config/testdata/config/output/out.bootstrap.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.cluster.json
hgctl/cmd/hgctl/config/testdata/config/output/out.cluster.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.endpoints.json
hgctl/cmd/hgctl/config/testdata/config/output/out.endpoints.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.listener.json
hgctl/cmd/hgctl/config/testdata/config/output/out.listener.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.route.json
hgctl/cmd/hgctl/config/testdata/config/output/out.route.yaml
hgctl/pkg/manifests/istiobase/Chart.yaml
hgctl/pkg/manifests/istiobase/README.md
hgctl/pkg/manifests/istiobase/crds/crd-all.gen.yaml
hgctl/pkg/manifests/istiobase/crds/crd-operator.yaml
hgctl/pkg/manifests/istiobase/templates/clusterrole.yaml
hgctl/pkg/manifests/istiobase/templates/clusterrolebinding.yaml
hgctl/pkg/manifests/istiobase/templates/crds.yaml
hgctl/pkg/manifests/istiobase/templates/default.yaml
hgctl/pkg/manifests/istiobase/templates/endpoints.yaml
hgctl/pkg/manifests/istiobase/templates/reader-serviceaccount.yaml
hgctl/pkg/manifests/istiobase/templates/role.yaml
hgctl/pkg/manifests/istiobase/templates/rolebinding.yaml
hgctl/pkg/manifests/istiobase/templates/serviceaccount.yaml
hgctl/pkg/manifests/istiobase/templates/services.yaml
hgctl/pkg/manifests/istiobase/values.yaml
hgctl/pkg/manifests/profiles/_all.yaml
hgctl/pkg/manifests/profiles/k8s.yaml
hgctl/pkg/manifests/profiles/local-docker.yaml
hgctl/pkg/manifests/profiles/local-k8s.yaml

github-actions

license-eye has totally checked 1000 files.

Valid	Invalid	Ignored	Fixed
398	32	570	0

Click to see the invalid file list

hgctl/cmd/hgctl/config/testdata/config/input/in.all.json
hgctl/cmd/hgctl/config/testdata/config/output/out.all.json
hgctl/cmd/hgctl/config/testdata/config/output/out.all.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.bootstrap.json
hgctl/cmd/hgctl/config/testdata/config/output/out.bootstrap.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.cluster.json
hgctl/cmd/hgctl/config/testdata/config/output/out.cluster.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.endpoints.json
hgctl/cmd/hgctl/config/testdata/config/output/out.endpoints.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.listener.json
hgctl/cmd/hgctl/config/testdata/config/output/out.listener.yaml
hgctl/cmd/hgctl/config/testdata/config/output/out.route.json
hgctl/cmd/hgctl/config/testdata/config/output/out.route.yaml
hgctl/pkg/manifests/istiobase/Chart.yaml
hgctl/pkg/manifests/istiobase/README.md
hgctl/pkg/manifests/istiobase/crds/crd-all.gen.yaml
hgctl/pkg/manifests/istiobase/crds/crd-operator.yaml
hgctl/pkg/manifests/istiobase/templates/clusterrole.yaml
hgctl/pkg/manifests/istiobase/templates/clusterrolebinding.yaml
hgctl/pkg/manifests/istiobase/templates/crds.yaml
hgctl/pkg/manifests/istiobase/templates/default.yaml
hgctl/pkg/manifests/istiobase/templates/endpoints.yaml
hgctl/pkg/manifests/istiobase/templates/reader-serviceaccount.yaml
hgctl/pkg/manifests/istiobase/templates/role.yaml
hgctl/pkg/manifests/istiobase/templates/rolebinding.yaml
hgctl/pkg/manifests/istiobase/templates/serviceaccount.yaml
hgctl/pkg/manifests/istiobase/templates/services.yaml
hgctl/pkg/manifests/istiobase/values.yaml
hgctl/pkg/manifests/profiles/_all.yaml
hgctl/pkg/manifests/profiles/k8s.yaml
hgctl/pkg/manifests/profiles/local-docker.yaml
hgctl/pkg/manifests/profiles/local-k8s.yaml

CH3CHO added 30 commits September 23, 2023 18:54

feat: Upgrade istio to 1.18 and envoy to 1.26

a0b1392

Move submodules to the external folder

b9aba7f

Update code files for new istio and envoy versions

689e1e7

Remove unnecessary replace statements in go.mod

a7fbbe6

Run "go mod tidy"

dacf0bb

Fix panics after starting up

9564c11

Fix the MCP cache syncing issue

9d08ee8

Update to istio 1.19.0 and envoy 1.27.0

da45f4e

Run "go mod tidy"

42720d7

Fix compilation errors

dfaec59

Fix unit tests

d9a1f40

fix: Add back URI rewrite support via regex

b5d8947

Merge remote-tracking branch 'upstream/main' into feat/istio-1.19.0

69586f1

fix: Re-generate files from wasm.proto

9fae3a4

Merge remote-tracking branch 'origin/main' into feat/istio-1.19.0

e777294

fix: Fix image building targets

82b60c6

Move submodules to its respective folders

12d9dc8

Fix local image building targets

e63997d

Switch to Higress tagged build tools to improve image loading speed

df8c814

Save the built envoy.tar.gz file in external/proxy/out folder

a28f76d

fix: Use patches to normalize envoy building process

4c29550

Merge remote-tracking branch 'upstream/main' into feat/istio-1.19.0

be77c59

Fix some compilation errors introduced by merging

672174f

fix: Fix envoy building process

11c612f

Fix more compilation errors introduced by merging

5a808ec

feat: Support Gateway API with Istio Gateway Controller

6d48138

Migrate istio gateway controller code files

32800f6

Update Istio codebase for Higress

a592112

feat: Update data plane service matching logic

5d3190a

feat: Support keeping labels and annotations by converting Gateway co…

e94aa35

…nfigs to xDS resources

rinfx had a problem deploying to image-registry-controller January 3, 2024 06:36 — with GitHub Actions Failure

rinfx had a problem deploying to image-registry-pilot January 3, 2024 06:44 — with GitHub Actions Error

rinfx had a problem deploying to image-registry-pilot January 3, 2024 06:44 — with GitHub Actions Failure

rinfx had a problem deploying to image-registry-controller January 3, 2024 06:44 — with GitHub Actions Failure

fix: Fix errors occurred when building hgctl (#761)

4faa86b

CH3CHO requested review from 2456868764 and WeixinX as code owners January 7, 2024 14:17

CH3CHO added 3 commits January 7, 2024 22:22

Merge remote-tracking branch 'upstream/main' into feat/istio-1.19.0

9bd34ec

Fix go module dependencies

0ba8cd2

Execute GitLab actions with Go 1.21.5

89fe086

CH3CHO added 5 commits January 18, 2024 10:51

Update envoy version

d19c59f

Downgrade to go 1.20

f6f4e81

Move hgctl into a sub-module

c13728e

Remove redundant replaces

d97854a

Merge remote-tracking branch 'upstream/main' into feat/istio-1.19.0

e29820f

github-actions bot reviewed Jan 23, 2024

View reviewed changes

support multi-arch building (#748)

0d93813

github-actions bot reviewed Jan 31, 2024

View reviewed changes

CH3CHO added 2 commits February 1, 2024 13:03

Apply 20231104-gatewayapi-catchall.patch

cba2218

Integrate 20230925-gateway-httproute.patch

9cda5e3

github-actions bot reviewed Feb 1, 2024

View reviewed changes

CH3CHO added 4 commits February 1, 2024 17:27

Merge remote-tracking branch 'upstream/main' into feat/istio-1.19.0

e327cd9

Fix some compilation errors

1aaeb85

Uncomment the entry of Higress CRD controllers

12a1c74

Merge remote-tracking branch 'upstream/main' into feat/istio-1.19.0

3e5d3c9

github-actions bot reviewed Mar 9, 2024

View reviewed changes

CH3CHO added 3 commits March 9, 2024 10:26

Fix a compilation error

ee3ee63

Exclude hgctl manifest and testdata from license check

8009db3

feat: Support collecting gateway access logs with Promtail (#846)

c93c565

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to Istio 1.19.0 and implement Gateway API support #717

Upgrade to Istio 1.19.0 and implement Gateway API support #717

CH3CHO commented Dec 20, 2023

codecov-commenter commented Jan 8, 2024 •

edited

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

github-actions bot left a comment

Upgrade to Istio 1.19.0 and implement Gateway API support #717

Are you sure you want to change the base?

Upgrade to Istio 1.19.0 and implement Gateway API support #717

Conversation

CH3CHO commented Dec 20, 2023

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

codecov-commenter commented Jan 8, 2024 • edited

Codecov Report

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot left a comment

Choose a reason for hiding this comment

codecov-commenter commented Jan 8, 2024 •

edited