Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test by adding time comparision granularity #4460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rRajivramachandran
Copy link

System Settings

Java: 11.0.20.1
Maven: 3.8.8

Test failure Reproduction

Command: mvn -pl . test -Dtest=com.alibaba.json.bvt.issue_2700.Issue2784#test_for_issue

[INFO] Running com.alibaba.json.bvt.issue_2700.Issue2784
[ERROR] Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.889 s <<< FAILURE! - in com.alibaba.json.bvt.issue_2700.Issue2784
[ERROR] com.alibaba.json.bvt.issue_2700.Issue2784.test_for_issue  Time elapsed: 0.531 s  <<< FAILURE!
junit.framework.AssertionFailedError: expected:<2023-11-11T11:38:15.749028> but was:<2023-11-11T11:38:15.749>
at com.alibaba.json.bvt.issue_2700.Issue2784.test_for_issue(Issue2784.java:21)

Root Cause

The issue arises because the serialization and de serialization for Model class defines milliseconds as the granularity here. However for the other object under comparision the exact system time java.time.LocalDateTime(upto nanoseconds precision) is considered. The test will only pass when the system time taken is an exact millisecond value(i.e microsecond and nanoseconds are zero). The pass scenario has been verified using the following patch

Fix

Compare the objects only upto millisecond granularity as this is the level of precision defined in the model.

Verification of fix

The test passes without any other changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant