New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #3672 #3675
Closed
Closed
Fix #3672 #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… transfer array id to write(), so it will appear null. <type>: - [x] Bug fix - [x] This change requires a documentation update Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #3675 +/- ##
============================================
- Coverage 80.32% 80.31% -0.02%
+ Complexity 7498 7495 -3
============================================
Files 157 157
Lines 28012 28014 +2
Branches 6762 6763 +1
============================================
- Hits 22502 22500 -2
- Misses 3487 3490 +3
- Partials 2023 2024 +1
Continue to review full report at Codecov.
|
The JSON.toJSONString(Object) and it's addition of PrettyFormat are same. Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
</subject> Branch: <type>: - [ ] Bug fix - [ ] Bug fix (Test) - [ ] New feature - [ ] Breaking change - [ ] Documentation update - [ ] This change requires a documentation update <body> <footer> Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
</subject> Branch: issue3672 <type>: - [ ] Bug fix - [x] Bug fix (Test) - [ ] New feature - [ ] Breaking change - [ ] Documentation update - [ ] This change requires a documentation update <body> <footer> Signed-off-by: Certseeds <51754303+Certseeds@users.noreply.github.com>
不要引入额外的代码格式化,导致行数更新太多,无法合并 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3672
in
ObjectArrayCodec.java
if use PrettyFormat, Do not transferarray id to write(), so it will appear "null"原有逻辑
没有传fieldName过去
现有逻辑
PS:
这里serializer.containsReference(item) == false内,改成
是否会有性能提升?