Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve PGTypeCastExpr #5919

Merged
merged 8 commits into from
May 22, 2024
Merged

Improve PGTypeCastExpr #5919

merged 8 commits into from
May 22, 2024

Conversation

ZhengguanLi
Copy link
Contributor

@ZhengguanLi ZhengguanLi commented May 15, 2024 •
edited

Changes:

  • Adding constructors, and implement clone() method fo PGTypeCastExpr class
  • Add constructors for SQLParameter
  • Use setExpr method in SQLExprStatement constructor to ensure the parent-child relationship is built

@ZhengguanLi ZhengguanLi changed the title Add clone method for PGTypeCastExpr Improve PGTypeCastExpr May 15, 2024
@lizongbo
Copy link
Collaborator

请补充相应的单元测试用例代码

@ZhengguanLi
Copy link
Contributor Author

请补充相应的单元测试用例代码

Done! @lizongbo

@lizongbo lizongbo merged commit a89d5bd into alibaba:master May 22, 2024
5 checks passed
@ZhengguanLi ZhengguanLi deleted the pr/PGTypeCastExpr-clone-impl branch May 22, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZhengguanLi @lizongbo