build: Lock to mockery minor version #1038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eric-Warehime
changed the title
winder
approved these changes
Jun 15, 2022
Codecov Report
@@ Coverage Diff @@
## develop #1038 +/- ##
===========================================
- Coverage 59.58% 59.52% -0.06%
===========================================
Files 45 45
Lines 8353 8353
===========================================
- Hits 4977 4972 -5
- Misses 2918 2922 +4
- Partials 458 459 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Mockery bumped the golang version without doing a major version bump of their package. This breaks us since we're just pulling v2 latest. More discussion vektra/mockery#456 about this decision and why they say not to use mockery via go install/go generate.
Test Plan
CI