Update sys to resolve golang 1.17 local build crash
#3157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3157 +/- ##
==========================================
+ Coverage 43.78% 43.79% +0.01%
==========================================
Files 391 391
Lines 86880 86880
==========================================
+ Hits 38038 38051 +13
+ Misses 42808 42796 -12
+ Partials 6034 6033 -1
Continue to review full report at Codecov.
|
ahangsu
force-pushed
the
fix/go1.17buildfail
branch
from
867a5ca
to
c7e6444
Compare
ahangsu
changed the title
go-isatty to resolve golang 1.17 local build crashsys to resolve golang 1.17 local build crash
tsachiherman
approved these changes
Oct 28, 2021
cce
pushed a commit
to cce/go-algorand
that referenced
this pull request
Oct 28, 2021
Summary @barnjamin mentioned in algorand#2899 that labstack/gommon/issues/46 has a similar issue. Should be fixed by up version of sys. Closing algorand#2899.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
@barnjamin mentioned in #2899 that labstack/gommon/issues/46 has a similar issue.
Should be fixed by up version of
sys. Closing #2899.