chore: export AlgoliaAnalytics #252
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 86b8fc5:
|
There was a problem hiding this comment.
reasonable, but not sure if it's needed for the algolia/instantsearch#4712 PR since createInsightsClient already is exposed
lib/entry-browser-cjs.ts
Outdated
| export { getRequesterForBrowser, getRequesterForNode }; | ||
| export { | ||
| getRequesterForBrowser, | ||
| getRequesterForNode, |
There was a problem hiding this comment.
I don't understand why browser exports the node requester, but that seems to already have been the case?
There was a problem hiding this comment.
Clearly it doesn't need to export it. It was there by mistake. I'll get rid of it in the v2.
There was a problem hiding this comment.
Is it still tree shaked off by builder?
https://github.com/algolia/instantsearch.js/pull/4712/files#diff-02b3ab8202d2644b709760f62e00f44461af131e42f694fec1f6388ef080af03R2-R5 |
eunjae-lee
changed the title
|
This PR has been changed from "Exporting AlgoliaAnalytics, getFunctionalInterface, getRequesterForBrowser, processQueue" to "Exporting AlgoliaAnalytics". |
|
What about importing from /insights in the InstantSearch test? |
good idea! then we can just close this PR. |
|
Closing this PR since we'll directly import the functions from the source in algolia/instantsearch@70cde71 (It's only used in the test cases in InstantSearch.js. If it needs to be properly exported for other usecases, then we will reconsider this PR.) |
This PR exports
AlgoliaAnalyticsto create insights client for those who want more control.Before, it was only possible to choose which requester to use.
This PR enables algolia/instantsearch#4712