Fix deprecation notices with Symfony 4.2 #273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the PHP 7.1 and 7.2 builds are broken even without this change. Needs to be investigated separately. |
alcaeus
force-pushed
the
fix-symfony-42-compat
branch
from
19cbc57
to
403c4b1
Compare
nunomaduro
suggested changes
Dec 3, 2018
alcaeus
force-pushed
the
fix-symfony-42-compat
branch
from
403c4b1
to
82f64cc
Compare
nunomaduro
approved these changes
Dec 4, 2018
|
Thanks for your work in this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per the issues, creating a tree builder without a root node is deprecated, as is the
ContainerAwareCommand. The latter can be replaced withContainerAwareInterface, but it's better to just explicitly wire dependencies. I've added a BC layer toSearchImportCommand, deprecating instantiating it without a manager registry. If none is given, the command falls back to fetching it from the container.Since this PR brings in new deprecations, SemVer requires tagging this as a minor release.
@julienbourdeau please let me know if I should populate the changelog and if there should be an upgrading-4.0 document to track upcoming BC breaks in a future major release.