This repository has been archived by the owner on Dec 30, 2022. It is now read-only.
feat(facets): add a new option "facetOrdering" to Menu, RefinementList & HierarchicalMenu #3067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit cc6f07c:
|
|
✔️ Deploy Preview for react-instantsearch ready! 🔨 Explore the source changes: cc6f07c 🔍 Inspect the deploy log: https://app.netlify.com/sites/react-instantsearch/deploys/60deb8c2afae78000740d2ba 😎 Browse the preview: https://deploy-preview-3067--react-instantsearch.netlify.app |
|
sorry, i'll review this tomorrow morning! |
eunjae-lee
approved these changes
Jun 30, 2021
packages/react-instantsearch-core/src/connectors/__tests__/connectHierarchicalMenu.js
Show resolved
Hide resolved
francoischalifour
approved these changes
Jul 1, 2021
…mentList & HierarchicalMenu If `facetOrdering` is enabled (the default behaviour), before the default sortBy is used, the result from renderingContent.facetOrdering.values is first checked. If that's present, it will be used to sort the items. You can still change that ordering afterwards with the existing transformItems, so if you are sorting in transformItems, you actually override the sorting done by facet ordering, and won't see the effect. To use facetOrdering, you thus need to remove any sorting done in transformItems. If there is a facetOrdering present in the index, but you don't want to use it for a certain widget, you need to explicitly pass `facetOrdering: false` to the widget or connector References: - [RFC 45](https://github.com/algolia/instantsearch-rfcs/blob/master/accepted/flexible-facet-values.md) - algolia/instantsearch#4784 - algolia/algoliasearch-helper-js#822
Haroenv
force-pushed
the
feat/facet-ordering-values
branch
from
0b32039
to
cc6f07c
Compare
eunjae-lee
approved these changes
Jul 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
facetOrderingis enabled (the default behaviour), before the default sortBy is used, the result from renderingContent.facetOrdering.values is first checked. If that's present, it will be used to sort the items.You can still change that ordering afterwards with the existing transformItems, so if you are sorting in transformItems, you actually override the sorting done by facet ordering, and won't see the effect. To use facetOrdering, you thus need to remove any sorting done in transformItems.
If there is a facetOrdering present in the index, but you don't want to use it for a certain widget, you need to explicitly pass
facetOrdering: falseto the widget or connectorReferences: