fix(RefinementList): prevent searchable component to refine on empty …

…list (#3059)
algolia · Jun 9, 2021 · 04f3644 · 04f3644
1 parent 408739b
commit 04f3644
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/packages/react-instantsearch-dom/src/components/List.js b/packages/react-instantsearch-dom/src/components/List.js
@@ -131,7 +131,7 @@ class List extends Component {
           onSubmit={e => {
             e.preventDefault();
             e.stopPropagation();
-            if (isFromSearch) {
+            if (isFromSearch && items.length > 0) {
               selectItem(items[0], this.resetQuery);
             }
           }}

diff --git a/packages/react-instantsearch-dom/src/components/__tests__/RefinementList.js b/packages/react-instantsearch-dom/src/components/__tests__/RefinementList.js
@@ -330,5 +330,34 @@ describe('RefinementList', () => {
 
       wrapper.unmount();
     });
+
+    it('hit enter on an empty search values results list should do nothing', () => {
+      const emptyRefinementList = (
+        <RefinementList
+          refine={refine}
+          searchable
+          searchForItems={searchForItems}
+          createURL={() => '#'}
+          items={[]}
+          isFromSearch={true}
+          canRefine={true}
+        />
+      );
+
+      refine.mockClear();
+      const wrapper = mount(emptyRefinementList);
+      const input = wrapper.find('input[type="search"]');
+      input.props().value = 'white';
+
+      wrapper.find('form').simulate('submit');
+
+      expect(refine.mock.calls).toHaveLength(0);
+      expect(input.props().value).toBe('white');
+
+      const selectedRefinements = wrapper.find('li');
+      expect(selectedRefinements).toHaveLength(0);
+
+      wrapper.unmount();
+    });
   });
 });