Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(recommend): introduce Recommend widgets #6115

Merged
merged 41 commits into from May 21, 2024
Merged

feat(recommend): introduce Recommend widgets #6115

merged 41 commits into from May 21, 2024

Conversation

aymeric-giraudet
Copy link
Member

@aymeric-giraudet aymeric-giraudet commented Apr 4, 2024 •
edited by dhayab

This PR serves as the base branch for the Recommend feature.

FX-2788

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Apr 4, 2024 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b9d90b5:

Sandbox Source
example-instantsearch-getting-started Configuration
example-react-instantsearch-getting-started Configuration
example-react-instantsearch-next-app-dir-example Configuration
example-react-instantsearch-next-routing-example Configuration
example-vue-instantsearch-getting-started Configuration

Base automatically changed from feat/helper-recommend-methods to master April 5, 2024 11:00
@aymeric-giraudet aymeric-giraudet force-pushed the feat/map-recommend-results branch 3 times, most recently from 2c1a3f9 to 69a9842 Compare April 5, 2024 13:05
@aymeric-giraudet aymeric-giraudet changed the title wip: map recommend results to widgets feat: map recommend results to widgets Apr 5, 2024
@aymeric-giraudet aymeric-giraudet marked this pull request as ready for review April 5, 2024 13:14
@raed667 raed667 added the Feature: Recommendations Providing recommendations of records or facets label Apr 8, 2024
dhayab
dhayab reviewed Apr 9, 2024
View reviewed changes
Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't seen assignees, is this PR ready for review? For me this would work, but might need adjustments to ensure numeric ids don't conflict easily when adding Recommend parameters and creating recommend results.

packages/algoliasearch-helper/index.d.ts Show resolved Hide resolved
@Haroenv
Copy link
Contributor

Haroenv commented Apr 18, 2024

would be good to rebase the first commits, and then "merge and rebase" the whole branch at the end (instead of squashing). Maybe it also should be marked as draft now until it's in a "ready to release" state?

@dhayab dhayab marked this pull request as draft April 18, 2024 16:24
@dhayab dhayab force-pushed the feat/map-recommend-results branch from fa726da to 3121f7a Compare April 19, 2024 08:12
@Haroenv Haroenv changed the title feat: map recommend results to widgets feat: add recommend Apr 19, 2024
@sarahdayan sarahdayan changed the title feat: add recommend feat(recommend): introduce Recommend widgets Apr 26, 2024
@Haroenv Haroenv force-pushed the feat/map-recommend-results branch from b7755fa to 828d0cb Compare May 21, 2024 08:22
aymeric-giraudet and others added 12 commits May 21, 2024 10:32
@aymeric-giraudet @dhayab
feat(recommend): map recommend results to widgets
b66ed89
@raed667 @dhayab
@aymeric-giraudet @sarahdayan
feat(recommend): introduce FrequentlyBoughtTogether UI component (#…
ddde6d2 
…6114)

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
@sarahdayan @dhayab
@raed667 @aymeric-giraudet
feat(recommend): introduce RelatedProducts UI component (#6129)
6b45ef0 
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
@dhayab
feat(recommend): set up base CSS styles for `frequentlyBoughtTogether…
bcbd36c 
…` widget (#6118)
@dhayab @sarahdayan
feat(recommend): set up base CSS styles for relatedProducts widget (#…
c40105d 
…6148)

---------

Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
@sarahdayan @dhayab
@raed667 @aymeric-giraudet
feat(recommend): introduce connectRelatedProducts connector (#6142)
8d6af5f 
Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Raed <raed.chammam@algolia.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
@raed667 @dhayab
@aymeric-giraudet @sarahdayan
feat(recommend): introduce connectFrequentlyBoughtTogether connector (
879f8a6 
#6117)

---------

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
@dhayab @raed667
@aymeric-giraudet @sarahdayan
feat(recommend): introduce frequentlyBoughtTogether widget (#6126)
8f0fa1f 
---------

Co-authored-by: Raed <raed.chammam@algolia.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
@dhayab
test(recommend): move connectFrequentlyBoughtTogether tests to CTS (#…
8b91bbe 
…6152)
@dhayab @raed667
@aymeric-giraudet @sarahdayan
test(recommend): setup CTS for frequentlyBoughtTogether (#6143)
eef1468 
---------

Co-authored-by: Raed <raed.chammam@algolia.com>
Co-authored-by: Aymeric Giraudet <aymeric.giraudet@algolia.com>
Co-authored-by: Sarah Dayan <5370675+sarahdayan@users.noreply.github.com>
@sarahdayan @dhayab
feat(recommend): harmonize UI component for FBT and Related Products (#…
865006b 
…6157)
@sarahdayan @dhayab
feat(recommend): introduce relatedProducts widget (#6154)
1278793
dhayab and others added 22 commits May 21, 2024 10:38
@dhayab
feat(recommend): introduce trendingItems widget (#6171)
186ccbe
@Haroenv @dhayab
feat(recommend): introduce useTrendingItems Hook (#6177)
31612b8 
FX-2852
@Haroenv @dhayab
feat(recommend): introduce <TrendingItems> widget (#6178)
e95da12 
* feat(recommend): introduce TrendingItems

FX-2853

* fix(recommend): correct type for generic base

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>

---------

Co-authored-by: Dhaya <154633+dhayab@users.noreply.github.com>
@Haroenv @dhayab
test(recommend): enforce model in CTS
a83af36
@aymeric-giraudet @dhayab
feat(recommend): cache results per $$id (#6181)
844db3a
@Haroenv @dhayab
feat(recommend): introduce LookingSimilar UI component (#6179)
29df464 
FX-2834
@Haroenv @dhayab
feat(recommend): introduce connectLookingSimilar connector (#6180)
9ae1cf5 
FX-2835
@Haroenv @dhayab
feat(recommend): introduce lookingSimilar widget (#6183)
3a1ed9b 
* feat(recommend): add lookingSimilar widget

FX-2836

* test(recommend): correct initialisation

* fix: pass fallbackParameters

* test: ensure parameters get forwarded correctly
@Haroenv @dhayab
feat(recommend): introduce Looking Similar React Hook and widget (#6184)
baf9ac3 
* feat(recommend): add LookingSimilar and useLookingSimilar

FX-2768

* test(cts): enable widget test
@Haroenv @dhayab
chore(recommend): rename tests for consistency
6a2ea21
@dhayab
chore(recommend): reference recommend widgets in exported types (#6186)
b7c459a
@sarahdayan @dhayab
feat(recommend): rename fallbackComponent into emptyComponent (#6190
5b9d0e8 
)
@Haroenv @dhayab
chore(recommend): change error message
de8303e
@dhayab @Haroenv
refactor(recommend): clean recommend state when removing widgets (#6192)
f3301d4 
---------

Co-authored-by: Haroen Viaene <hello@haroen.me>
@Haroenv @dhayab
refactor(recommend): rename return type consistently to items (#6197)
6a38683 
FX-2857
@Haroenv @dhayab
refactor(recommend): compute classNames only once (#6198)
b952bcc 
* refactor(ui-components): compute classNames only once

FX-2860

* fix name
@dhayab
feat(recommend): support escapeHTML in recommend widgets (#6199)
ff261a5
@dhayab @Haroenv
test(recommend): use shared mock client with recommendations in tests (…
93a2a4b 
…#6201)

---------

Co-authored-by: Haroen Viaene <hello@haroen.me>
@dhayab
refactor(recommend): ensure unicity of recommend queries (#6203)
7a0f9e2
@Haroenv @dhayab
refactor(recommend): rename maxRecommendations to limit (#6196)
a58e01f 
This is consistent with other widgets that don't have pagination like refinementList
@Haroenv @dhayab
refactor(recommend): prevent network request (#6205)
b6d4f04
@dhayab
chore: bump bundlesize
b9d90b5
@dhayab dhayab force-pushed the feat/map-recommend-results branch from 828d0cb to b9d90b5 Compare May 21, 2024 08:44
@dhayab dhayab marked this pull request as ready for review May 21, 2024 08:59
dhayab
dhayab approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@dhayab dhayab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@dhayab dhayab merged commit b0a10f0 into master May 21, 2024
12 checks passed
@dhayab dhayab deleted the feat/map-recommend-results branch May 21, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhayab dhayab dhayab approved these changes

@sarahdayan sarahdayan Awaiting requested review from sarahdayan

@Haroenv Haroenv Awaiting requested review from Haroenv

Assignees
No one assigned
Labels
Feature: Recommendations Providing recommendations of records or facets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aymeric-giraudet @Haroenv @dhayab @raed667 @sarahdayan