Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dynamicWidgets): add default attributesToRender & transformItems #4776

Merged
merged 7 commits into from Jun 11, 2021

Conversation

Haroenv
Copy link
Contributor

@Haroenv Haroenv commented Jun 8, 2021

Summary

Retrieves the default attributesToRender from the result, and gives a default to transformItems now

Result

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 24b7895:

Sandbox Source
InstantSearch.js Configuration

@Haroenv Haroenv marked this pull request as ready for review June 11, 2021 08:27
@Haroenv Haroenv requested review from a team, tkrugg, francoischalifour and eunjae-lee and removed request for a team and tkrugg June 11, 2021 08:27
Copy link
Contributor

@eunjae-lee eunjae-lee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great without the temporary code any more!

@Haroenv Haroenv merged commit 44dab44 into master Jun 11, 2021
@Haroenv Haroenv deleted the feat/dynamic-widgets-default branch June 11, 2021 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants