fix(lite): use lite algoliasearch build (js client) #1037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @jerskouille, @redox and @bobylito to be potential reviewers |
vvo
changed the title
vvo
changed the title
vvo
changed the title
fixes #1024 by forcing to load /lite and avoid bad resolve of the browser field. This could break if people were using search.client to do things like indexing. But we do document this as an API entry. We only have an infinite scroll tutorial using the client passed to the helper. Thus I had to make browse and browseFrom part of the lite build.
|
I think we're ok for the indexing part, people should not be using instantsearch to do any indexing. Ok for the browse, I did not know we could do browser with a search-only key. Maybe only with a key with specific ACL? LGTM |
No you cannot but still it's a "search" operation available with specific keys. |
|
As for the indexing part, people can use instantsearch.js (example: back office application). Truth is that we do not expose the client anywhere in an official way. So people willing to do so should include it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1024 by forcing to load /lite and avoid bad resolve of the
browser field.
This could break if people were using search.client to do things like
indexing. But we do document this as an API entry. We only have an
infinite scroll tutorial using the client passed to the helper. Thus I
had to make browse and browseFrom part of the lite build.