fix(python): chunked_batch helper #3069
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
鉁旓笍 Code generated!
|
|
@millotp @morganleroi don't want to bother you, but could you review this PR? It should fix a bug in the Python API client. |
millotp
reviewed
May 17, 2024
| @@ -223,7 +223,7 @@ | |||
| responses: List[BatchResponse] = [] | |||
| for i, obj in enumerate(objects): | |||
| requests.append(BatchRequest(action=action, body=obj)) | |||
| if i % batch_size == 0: | |||
| if len(requests) == batch_size or i == len(objects) - 1: | |||
There was a problem hiding this comment.
I don't think you can take the length of a Iterable type, because the length is determined after iterating over it
|
I think we have that issue in other clients too, i'll add a ticket to our backlog just to be sure alternatively, a universal solution, might be to first build a list of list of batch by iterating over all objects, then iterating on the list to do the requests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃Л What and Why
Fix a bug in the
chunked_batchhelper for the Python API client.The bug shows when using the
replace_all_objectshelper鈥攖he new index won't have all the records:0 % batch_size == 0) will be sent.1 + n x 1,000records will be sent. The records after the last integer multiple ofbatch_sizewon't be sent.Changes included:
requestarray reaches thebatch_size, or when the end of theobjectslist is reached.objects"list" inreplace_all_objectsandchunked_batchto be anIterableinstead of an explicit list. This makes it possible to use also with things like list comprehensions.馃И Test
No additional test added (didn't quite know how we could test this, as the API is mocked in these tests... we would have to test whether the replaced index has the correct records in it).