This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix: prevent prototype pollution in rare error-cases #923
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user-provided search parameter is used to instantiate search parameters, it was possible to construct it in such a way that
constructor.prototype
is attempted to be written. That throws an error, but if the error would be caught, the resulting injection still happened.This PR fixes that (small) vulnerability by ensuring
constructor
, is skipped, just like__proto__
.fixes #922
This is similar/a follow-up to #880