Skip to content
This repository has been archived by the owner on Jul 11, 2023. It is now read-only.

feat(facets): when * is present, only send that parameter #874

Merged
merged 8 commits into from Oct 8, 2021
Merged

feat(facets): when * is present, only send that parameter #874

merged 8 commits into from Oct 8, 2021

Commits on Oct 7, 2021

  1. feat(facets): add expandWildcardFacets parameter to process * in facets 

    When * is present in facets, we don't need to request the individual facet values of each facet that's declared, as * will already request it.

With a new parameter "expandWildcardFacets", we filter out all facets that aren't * itself or -something. The new parameter doesn't add "*" automatically, it still

To decide:
- is "-something" worth caring about?
- when * isn't present, should no facets be requested or the default ones?
- is this the right location, maybe the client cache should have similar logic instead?

see: https://github.com/algolia/algoliasearch-helper-js/issues/391
    @Haroenv
    Haroenv committed Oct 7, 2021
    Copy the full SHA
    5930e4a View commit details
    Browse the repository at this point in the history

  2. remove reference to non-existing -

    @Haroenv
    Haroenv committed Oct 7, 2021
    Copy the full SHA
    b66f237 View commit details
    Browse the repository at this point in the history

  3. don't inject *

    @Haroenv
    Haroenv committed Oct 7, 2021
    Copy the full SHA
    24fddc9 View commit details
    Browse the repository at this point in the history

  4. rephrase

    @Haroenv
    Haroenv committed Oct 7, 2021
    Copy the full SHA
    2fcd00b View commit details
    Browse the repository at this point in the history

  5. remove the parameter, by default!

    @Haroenv
    Haroenv committed Oct 7, 2021
    Copy the full SHA
    8659a37 View commit details
    Browse the repository at this point in the history

  6. Update src/requestBuilder.js

    @Haroenv
    Haroenv committed Oct 7, 2021
    Copy the full SHA
    b765df5 View commit details
    Browse the repository at this point in the history

  7. fix

    @Haroenv
    Haroenv committed Oct 7, 2021
    Copy the full SHA
    90ca424 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2021

  1. Update test/spec/requestBuilder.js 

    Co-authored-by: François Chalifour <francoischalifour@users.noreply.github.com>
    @Haroenv @francoischalifour
    Haroenv and francoischalifour committed Oct 8, 2021
    Copy the full SHA
    1b4093d View commit details
    Browse the repository at this point in the history