This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(SearchParameters): ignore invalid parameters #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These parameters could be used maliciously, so are explicilty not allowed in merge
Haroenv
requested review from
a team,
dhayab and
tkrugg
and removed request for
a team
sarahdayan
reviewed
Oct 15, 2021
francoischalifour
approved these changes
Oct 18, 2021
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2023
If a user-provided search parameter is used to instantiate search parameters, it was possible to construct it in such a way that `constructor.prototype` is attempted to be written. That throws an error, but if the error would be caught, the resulting injection still happened. This PR fixes that (small) vulnerability by ensuring `constructor`, is skipped, just like `__proto__`. fixes #922 This is similar/a follow-up to #880
Haroenv
added a commit
that referenced
this pull request
Jan 9, 2023
If a user-provided search parameter is used to instantiate search parameters, it was possible to construct it in such a way that `constructor.prototype` is attempted to be written. That throws an error, but if the error would be caught, the resulting injection still happened. This PR fixes that (small) vulnerability by ensuring `constructor`, is skipped, just like `__proto__`. fixes #922 This is similar/a follow-up to #880
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
…ch-helper-js#880) * fix(SearchParameters): ignore invalid parameters These parameters could be used maliciously, so are explicilty not allowed in merge * clearer test
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
* fix(SearchParameters): ignore invalid parameters (algolia/algoliasearch-helper-js#880) algolia/algoliasearch-helper-js@2a2a45f
dhayab
pushed a commit
to algolia/instantsearch
that referenced
this pull request
Jul 10, 2023
…search-helper-js#923) If a user-provided search parameter is used to instantiate search parameters, it was possible to construct it in such a way that `constructor.prototype` is attempted to be written. That throws an error, but if the error would be caught, the resulting injection still happened. This PR fixes that (small) vulnerability by ensuring `constructor`, is skipped, just like `__proto__`. fixes algolia/algoliasearch-helper-js#922 This is similar/a follow-up to algolia/algoliasearch-helper-js#880
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These parameters could be used maliciously, so are explicilty not allowed in merge