Fix conflict with standard library for typing dependency #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nunomaduro
suggested changes
May 16, 2019
There was a problem hiding this comment.
Maybe we also need to update https://github.com/algolia/algoliasearch-client-python/blob/master/setup.cfg right?
|
@nunomaduro You're correct. I've updated that too, though I'm not familiar with how the .cfg is parsed and if, for example, any escaping is required on the quotations. |
|
@nunomaduro let me know if you think this needs additional changes. |
|
@fernando-mc Thanks! This can wait until Monday? |
|
@nunomaduro sure! No reason to deploy on a Friday 😉 I have a workaround for the moment. |
|
Thanks so much for making this PR @fernando-mc! We just ran into the same issue. |
nunomaduro
approved these changes
May 21, 2019
|
Thank you for this! Great contribution! |
shortcuts
added a commit
that referenced
this pull request
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your change
I've changed the typing requirement to only be installed if the python version is less than 3.5. This is because
typingis included in the standard library for 3.5 and above. You can read more here https://docs.python.org/3/library/typing.html and in issue #422What problem is this fixing?
The issue described in #422