Handling of params array in the $queries array for multipleQueries method #663
+25
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damcou
changed the title
chloelbn
approved these changes
Feb 1, 2021
damcou
added a commit
that referenced
this pull request
Feb 9, 2021
damcou
added a commit
that referenced
this pull request
Feb 11, 2021
chloelbn
added a commit
that referenced
this pull request
Feb 16, 2021
* Indexing and Settings tests for SearchIndexTest.php * Add SearchTest method * Add SynonymsTest method * Add testQueryRules method * Add testBatching method * Add testReplacing and testExists methods + move sample data * Add SearchClientTest.php * Add multiQueries test * Adding AccountTest.php and remove usage of SyncClient * Adding SecuredApiKeysTest * Adding AnalyticsClientTest.php * Adding AnalyticsClientTest.php * Adding InsightsClientTest.php * Adding RecommendationClientTest.php + CS fixer * Adding Mcm tests * Add stopAbTest() test * Remove unnecessary files * Handling of param array in the $queries array for multipleQueries method (#663) * Remove unnecessary files * First required changes * Removing self::assert* notations * fix(cts): delete indexes initialisation * Using wait() on saveObject() rather than multiResponse * Removing all static arrays for indices * Removing unwanted setPersonalizationStrategy call * use secured index name * Required changes after code review * Adding loop to check if indices exist before additing the A/B Tests * Adding security into loops * Set cpts to 10 * Set cpts to 20 * Set cpts to 10 * Set cpts to 10 Co-authored-by: Chloe Liban <chloe.liban@gmail.com>
chloelbn
pushed a commit
that referenced
this pull request
Apr 5, 2021
chloelbn
added a commit
that referenced
this pull request
Apr 5, 2021
* Indexing and Settings tests for SearchIndexTest.php * Add SearchTest method * Add SynonymsTest method * Add testQueryRules method * Add testBatching method * Add testReplacing and testExists methods + move sample data * Add SearchClientTest.php * Add multiQueries test * Adding AccountTest.php and remove usage of SyncClient * Adding SecuredApiKeysTest * Adding AnalyticsClientTest.php * Adding AnalyticsClientTest.php * Adding InsightsClientTest.php * Adding RecommendationClientTest.php + CS fixer * Adding Mcm tests * Add stopAbTest() test * Remove unnecessary files * Handling of param array in the $queries array for multipleQueries method (#663) * Remove unnecessary files * First required changes * Removing self::assert* notations * fix(cts): delete indexes initialisation * Using wait() on saveObject() rather than multiResponse * Removing all static arrays for indices * Removing unwanted setPersonalizationStrategy call * use secured index name * Required changes after code review * Adding loop to check if indices exist before additing the A/B Tests * Adding security into loops * Set cpts to 10 * Set cpts to 20 * Set cpts to 10 * Set cpts to 10 Co-authored-by: Chloe Liban <chloe.liban@gmail.com>
chloelbn
added a commit
that referenced
this pull request
Apr 5, 2021
* feat: add custom dictionary methods (tests still WIP) * chore: add docblocks * feat: update tests * debug: use API key dealer * Revert "debug: use API key dealer" This reverts commit dcf05df. * feat: refactor tests to rely on objectID checks instead of nbHits * feat: finzalize CTS * chore: address feedback * chore: remove unused method * Add missing part of the url for stopABTest() method (#666) * Handling of param array in the $queries array for multipleQueries method (#663) * Add Algolia CTS (#665) * Indexing and Settings tests for SearchIndexTest.php * Add SearchTest method * Add SynonymsTest method * Add testQueryRules method * Add testBatching method * Add testReplacing and testExists methods + move sample data * Add SearchClientTest.php * Add multiQueries test * Adding AccountTest.php and remove usage of SyncClient * Adding SecuredApiKeysTest * Adding AnalyticsClientTest.php * Adding AnalyticsClientTest.php * Adding InsightsClientTest.php * Adding RecommendationClientTest.php + CS fixer * Adding Mcm tests * Add stopAbTest() test * Remove unnecessary files * Handling of param array in the $queries array for multipleQueries method (#663) * Remove unnecessary files * First required changes * Removing self::assert* notations * fix(cts): delete indexes initialisation * Using wait() on saveObject() rather than multiResponse * Removing all static arrays for indices * Removing unwanted setPersonalizationStrategy call * use secured index name * Required changes after code review * Adding loop to check if indices exist before additing the A/B Tests * Adding security into loops * Set cpts to 10 * Set cpts to 20 * Set cpts to 10 * Set cpts to 10 Co-authored-by: Chloe Liban <chloe.liban@gmail.com> * chore(CTS): add retry on tests (#672) * chore(cts): fix api keys test * chore(CTS): fix flakiness * Revert "feat: custom dictionaries (#662)" This reverts commit d4e3112. * chore: address feedback * chore: remove unused method * chore(test): fix helper call * fix: rebase Co-authored-by: Devin Beeuwkes <devin.beeuwkes@algolia.com> Co-authored-by: Damien Couchez <damien.couchez@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deals with the changes proposed in PR #637 with the following additions :