Chore: improve crash reporting (fixes eslint#11304)

Add line number to the output in the event of a rule crash
alexzherdev · Mar 2, 2019 · 35b722f · 35b722f
1 parent 341140f
commit 35b722f
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/lib/linter.js b/lib/linter.js
@@ -747,10 +747,15 @@ function runRules(sourceCode, configuredRules, ruleMapper, parserOptions, parser
     nodeQueue.forEach(traversalInfo => {
         currentNode = traversalInfo.node;
 
-        if (traversalInfo.isEntering) {
-            eventGenerator.enterNode(currentNode);
-        } else {
-            eventGenerator.leaveNode(currentNode);
+        try {
+            if (traversalInfo.isEntering) {
+                eventGenerator.enterNode(currentNode);
+            } else {
+                eventGenerator.leaveNode(currentNode);
+            }
+        } catch (err) {
+            err.currentNode = currentNode;
+            throw err;
         }
     });
 
@@ -903,6 +908,9 @@ module.exports = class Linter {
         } catch (err) {
             debug("An error occurred while traversing");
             debug("Filename:", options.filename);
+            if (err.currentNode) {
+                debug("Line:", err.currentNode.loc.start.line);
+            }
             debug("Parser Options:", parserOptions);
             debug("Parser Path:", parserName);
             debug("Settings:", settings);