Merge pull request #9 from alexkosj/fix-tests

remove py3.7 test runs
alexkosj · Jul 18, 2020 · 3994bac · 3994bac
2 parents e879adf + 9c77a41
commit 3994bac
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 7 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -7,7 +7,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        python-version: [3.6, 3.7, 3.8]
+        python-version: [3.6, 3.8]
 
     steps:
     - uses: actions/checkout@v2

diff --git a/tests/test_pruun.py b/tests/test_pruun.py
@@ -1,4 +1,4 @@
-import os.path
+import os
 import subprocess
 
 from click.testing import CliRunner
@@ -11,29 +11,41 @@ def test_deployment_package():
     Test parsing of installed packages, creation of .zip, and finally validate integrity of .zip.
     """
     runner = CliRunner()
+    lambda_file_name = "handler.py"
+    package_name = "deployment_package.zip"
+
     with runner.isolated_filesystem():
-        with open("handler.py", "w") as f:  # create dummy lambda handler file
+        with open(lambda_file_name, "w") as f:  # create dummy lambda handler file
             pass
 
-            result = runner.invoke(pruun, ["package", "handler.py"])
+            result = runner.invoke(pruun, ["package", lambda_file_name])
 
             # check for no exceptions
             assert result.exit_code == 0
 
             # check for existence of .zip file
-            assert os.path.isfile("deployment_package.zip") == True
+            assert os.path.isfile(package_name) == True
 
             # verify integrity of .zip
             depens = get_dependency_names()
             for depen in depens:
                 underscored_name = depen.replace("-", "_").strip()
-                cmd = f"unzip -l deployment_package.zip {underscored_name}*"
+                cmd = f"unzip -l {package_name} {underscored_name}*"
                 subprocess.run(
                     cmd,
                     stdout=subprocess.DEVNULL,
                     stderr=subprocess.STDOUT,
                     shell=True,
                     check=True,
-                )
+                )  # check .zip for all installed packages
+
+            cmd = f"unzip -l {package_name} {lambda_file_name}*"
+            subprocess.run(
+                cmd,
+                stdout=subprocess.DEVNULL,
+                stderr=subprocess.STDOUT,
+                shell=True,
+                check=True,
+            )  # check .zip for lambda handler file
 
             f.close()