Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

completion: fix zsh completion #727

Closed
wants to merge 1 commit into from
Closed

completion: fix zsh completion #727

wants to merge 1 commit into from

Conversation

chenrui333
Copy link

@chenrui333 chenrui333 commented Aug 5, 2022

Description

Update zsh completion per spf13/cobra#1690

Also relates to Homebrew/homebrew-core#107394

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

Are you a GitHub Sponsor yet (Yes/No?)

  • Yes
  • No

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get -o markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have tested this on arm, or have added code to prevent deployment

Update zsh completion per spf13/cobra#1690

Signed-off-by: Rui Chen <rui@chenrui.dev>
@derek derek bot added the new-contributor label Aug 5, 2022
@chenrui333
Copy link
Author

Actually this is not needed, my bad.

@chenrui333 chenrui333 closed this Aug 5, 2022
@chenrui333 chenrui333 deleted the fix-zsh-completion branch August 5, 2022 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant