Make Url and MultiHostUrl subclassable (pydantic#660)

alexdrydew · Jun 12, 2023 · 55de89a · 55de89a
1 parent d488194
commit 55de89a
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/src/url.rs b/src/url.rs
@@ -12,7 +12,7 @@ use crate::SchemaValidator;
 
 static SCHEMA_DEFINITION_URL: GILOnceCell<SchemaValidator> = GILOnceCell::new();
 
-#[pyclass(name = "Url", module = "pydantic_core._pydantic_core")]
+#[pyclass(name = "Url", module = "pydantic_core._pydantic_core", subclass)]
 #[derive(Clone)]
 #[cfg_attr(debug_assertions, derive(Debug))]
 pub struct PyUrl {
@@ -147,7 +147,7 @@ impl PyUrl {
     }
 }
 
-#[pyclass(name = "MultiHostUrl", module = "pydantic_core._pydantic_core")]
+#[pyclass(name = "MultiHostUrl", module = "pydantic_core._pydantic_core", subclass)]
 #[derive(Clone)]
 #[cfg_attr(debug_assertions, derive(Debug))]
 pub struct PyMultiHostUrl {

diff --git a/tests/serializers/test_url.py b/tests/serializers/test_url.py
@@ -86,3 +86,13 @@ def test_custom_serializer():
 
     multi_host_url = MultiHostUrl('https://ex.com,ex.org/path')
     assert s.to_python(multi_host_url) == multi_host_url
+
+
+@pytest.mark.parametrize('base_class', [Url, MultiHostUrl])
+def test_url_subclass(base_class):
+    class MyUrl(base_class):
+        def some_method(self):
+            return self.path + '-success'
+
+    m = MyUrl('http://ex.com/path')
+    assert m.some_method() == '/path-success'