feat: support handle very large uid/gid in PAX style tar #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
adamqqqplay
force-pushed
the
fix-pax-uid-gid
branch
from
32b2260
to
8e9e82d
Compare
jiangliu
reviewed
Jul 18, 2023
src/archive.rs
Outdated
| @@ -275,7 +275,7 @@ impl<'a, R: Read> Iterator for Entries<'a, R> { | |||
| impl<'a> EntriesFields<'a> { | |||
| fn next_entry_raw( | |||
| &mut self, | |||
| pax_size: Option<u64>, | |||
| pax_extensions: &Option<Vec<u8>>, | |||
There was a problem hiding this comment.
How about using pax_extensions: Option<&[u8]>>?
jiangliu
reviewed
Jul 18, 2023
src/archive.rs
Outdated
| let mut pax_gid: Option<u64> = None; | ||
| if let Some(pax_extensions_ref) = &pax_extensions { | ||
| pax_size = pax_extensions_value(pax_extensions_ref, PAX_SIZE); | ||
| pax_uid = pax_extensions_value(pax_extensions_ref, PAX_UID); |
There was a problem hiding this comment.
How about
if let Some(uid) = pax_extensions_value(pax_extensions_ref, PAX_UID) {
header.set_uid(uid);
}
Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
adamqqqplay
force-pushed
the
fix-pax-uid-gid
branch
from
8e9e82d
to
c73e74b
Compare
This commit add process to read large uid/gid from PAX extensions to fix very large UIDs/GIDs (>=2097151, limit of USTAR tar) lost in PAX style tar during unpack. Fix: alexcrichton#332 Signed-off-by: Qinqi Qu <quqinqi@linux.alibaba.com>
adamqqqplay
force-pushed
the
fix-pax-uid-gid
branch
from
c73e74b
to
17f97d2
Compare
|
@alexcrichton Hi Alex, could you take a look when you have time? Thanks! |
|
@alexcrichton Thanks for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit add process to read large uid/gid from PAX extensions
to fix very large UIDs/GIDs (>=2097151, limit of USTAR tar) lost
in PAX style tar during unpack.
Fix: #332