Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an append_link() method to handle long link targets #273

Merged
merged 1 commit into from Nov 19, 2021

Commits on Nov 18, 2021

  1. Add an append_link() method to handle long link targets

    We should support appending long symlink targets, because this
    occurs in real world filesystems.  In my case, RPM set up
    `.build-id` symlinks which can get long.
    
    Add an `append_link()` method following the precendent of
    `append_path()` - we're just supporting *two* potentially
    long filenames.
    
    As a side benefit, we can just do the `std::io::empty()` dance
    internally and not require the caller to specify it.
    
    The addition of special case `append()` methods is unfortunate,
    because the header API methods are then really an attractive nuisance.
    We should potentially consider deprecating them.
    
    Closes: alexcrichton#192
    cgwalters committed Nov 18, 2021
    Copy the full SHA
    02a9426 View commit details
    Browse the repository at this point in the history