Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly infer ranlib/ar for cross-gcc toolchains #164

Closed
wants to merge 2 commits into from

Commits on Oct 26, 2022

  1. Correctly infer ranlib/ar for cross-gcc toolchains

    A second try at alexcrichton#163.
    
    The GCC convention is that if the toolchain is named `$target-gnu-gcc`,
    then ranlib and ar will be available as `$target-gnu-gcc-ranlib` and
    `$target-gnu-gcc-ar` respectively. The code as written would infer them
    to be `$target-gnu-{ranlib,ar}`, which will only work if the tools from
    `binutils` (which follow that convention) are on `$PATH`.
    
    I've also updated the logic in line with the `cc` crate to check that
    the inferred `AR`/`RANLIB` is actually executable before setting it as
    an override.
    
    See also rust-lang/cc-rs#736.
    Jon Gjengset committed Oct 26, 2022
    Configuration menu
    Copy the full SHA
    c13be3c View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2022

  1. Prefer non-gcc-ar/ranlib

    Sometimes `gcc-ar` is broken, so when both are available we should
    prefer non-gcc-ar. See also rust-lang/cc-rs#741.
    Jon Gjengset committed Oct 31, 2022
    Configuration menu
    Copy the full SHA
    2683057 View commit details
    Browse the repository at this point in the history