Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix server worker is blocked #565

Merged
merged 2 commits into from Dec 4, 2023
Merged

Conversation

lizongying
Copy link
Contributor

When baseURL is not the root directory:
Uncaught (in promise) DOMException: Failed to register a ServiceWorker for scope ('https://lizongying.github.io/') with script ('https://lizongying.github.io/go-crawler/docs/sw.js'): The path of the provided scope ('/') is not under the max scope allowed ('/go-crawler/docs/'). Adjust the scope, move the Service Worker script, or use the Service-Worker-Allowed HTTP header to allow the scope.

@alex-shpak
Copy link
Owner

LGTM, I also updated manifest.json to also use relURL
Thanks!

@alex-shpak alex-shpak merged commit 14e14f6 into alex-shpak:master Dec 4, 2023
2 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants