Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Fix issues 352 & ♻ issues 362 #358

Closed
wants to merge 6 commits into from

Conversation

vicevolf
Copy link
Contributor

Solve this problem:
#352

The Reason:
gohugoio/hugo#8688

Solve this problem:
alex-shpak#352

The Reason:
gohugoio/hugo#8688
@alex-shpak
Copy link
Owner

alex-shpak commented Jul 1, 2021

Interesting, probably some special condition in hugo.
I will do some poking around before merging.

Thanks for the PR 👍

@vicevolf
Copy link
Contributor Author

Solve this problem:
#362

The Reason:
https://discourse.gohugo.io/t/how-to-open-link-in-a-new-tab-with-hugo-book/33872/2?u=volfclub

The Solution:
https://discourse.gohugo.io/t/how-to-open-link-in-a-new-tab-with-hugo-book/33872/5?u=volfclub

layouts/shortcodes/columns.html

<div class="book-columns flex flex-wrap">
  {{ range split .Inner "<--->" }}
  <div class="flex-even markdown-inner">
    {{ . | $.Page.RenderString }}
  </div>
  {{ end }}
</div>

@vicevolf vicevolf changed the title 🐞 Fix issues 352 🐞 Fix issues 352 & ♻ issues 362 Jul 18, 2021
@alex-shpak
Copy link
Owner

Well, I wasn't able to reproduce case with page content not refreshing.
And in your website you can organise content as you want, so I don't see much point in changing content to content.en in exampleSite as it will be easier to understand for users who don't use multilang mode.

But please move RenderString change to another PR, that function was introduced in 0.62, so now it is safe to add.

@alex-shpak
Copy link
Owner

Linked issue is good guess, but doesn't explain why that happens 🤷

@alex-shpak
Copy link
Owner

Lets see, I will check a bit more.

@vicevolf
Copy link
Contributor Author

Well, I wasn't able to reproduce case with page content not refreshing.
And in your website you can organise content as you want, so I don't see much point in changing content to content.en in exampleSite as it will be easier to understand for users who don't use multilang mode.

But please move RenderString change to another PR, that function was introduced in 0.62, so now it is safe to add.

Refreshing Issue,Try this Repo https://github.com/volfclub/fourry - content.zh/_index.md .

Linked issue, Because if you need Render Hooks, which markdownify doesn’t currently support .

@alex-shpak
Copy link
Owner

nah, Render Hooks is fine, can be merged, just please move to separate Pull Request.

@alex-shpak
Copy link
Owner

alex-shpak commented Feb 14, 2022

Well, seems like fix is not coming from hugo developers,
Can you please cleanup PR to only container rename of content folder? so I can merge it.

@alex-shpak alex-shpak closed this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants