fix(dart_frog): Response.json() overwrites content-type header (f…

…elangel#596)
alestiago · Apr 18, 2023 · 76c3d9d · 76c3d9d
1 parent 0ee1422
commit 76c3d9d
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/.gitignore b/.gitignore
@@ -1 +1,2 @@
-.idea
+.idea
+.vscode/settings.json
diff --git a/packages/dart_frog/lib/src/response.dart b/packages/dart_frog/lib/src/response.dart
@@ -55,7 +55,8 @@ class Response {
           body: body != null ? jsonEncode(body) : null,
           headers: {
             ...headers,
-            HttpHeaders.contentTypeHeader: ContentType.json.value,
+            if (!headers.containsKey(HttpHeaders.contentTypeHeader))
+              HttpHeaders.contentTypeHeader: ContentType.json.value,
           },
         );
 

diff --git a/packages/dart_frog/test/src/response_test.dart b/packages/dart_frog/test/src/response_test.dart
@@ -184,6 +184,17 @@ void main() {
         final response = Response.json();
         expect(response.json(), completion(isEmpty));
       });
+
+      test('has correct content-type when overriden in headers', () {
+        final headers = <String, String>{
+          HttpHeaders.contentTypeHeader: ContentType.html.value,
+        };
+        final response = Response.json(headers: headers);
+        expect(
+          response.headers[HttpHeaders.contentTypeHeader],
+          equals(ContentType.html.value),
+        );
+      });
     });
   });
 }