refactor(examples): upgrade to Very Good Analysis 4.0.0 (felangel#537)

alestiago · Feb 13, 2023 · 644bbd5 · 644bbd5
1 parent 2ea3109
commit 644bbd5
Show file tree

Hide file tree

Showing 23 changed files with 26 additions and 20 deletions.
diff --git a/.github/workflows/examples_counter.yaml b/.github/workflows/examples_counter.yaml
@@ -7,6 +7,7 @@ concurrency:
 on:
   pull_request:
     paths:
+      - "examples/counter/pubspec.yaml"
       - "examples/counter/routes/**"
       - "examples/counter/lib/**"
       - "examples/counter/test/**"

diff --git a/.github/workflows/examples_echo.yaml b/.github/workflows/examples_echo.yaml
@@ -7,6 +7,7 @@ concurrency:
 on:
   pull_request:
     paths:
+      - "examples/echo/pubspec.yaml"
       - "examples/echo/routes/**"
       - "examples/echo/lib/**"
       - "examples/echo/test/**"

diff --git a/.github/workflows/examples_hello_world.yaml b/.github/workflows/examples_hello_world.yaml
@@ -7,7 +7,7 @@ concurrency:
 on:
   pull_request:
     paths:
-      - "examples/hello_world/routes/**"
+      - "examples/hello_world/pubspec.yaml"
       - "examples/hello_world/lib/**"
       - "examples/hello_world/test/**"
       - "examples/hello_world/e2e/**"

diff --git a/.github/workflows/examples_kitchen_sink.yaml b/.github/workflows/examples_kitchen_sink.yaml
@@ -7,6 +7,7 @@ concurrency:
 on:
   pull_request:
     paths:
+      - "examples/kitchen_sink/pubspec.yaml"
       - "examples/kitchen_sink/routes/**"
       - "examples/kitchen_sink/lib/**"
       - "examples/kitchen_sink/test/**"

diff --git a/.github/workflows/examples_todos.yaml b/.github/workflows/examples_todos.yaml
@@ -7,9 +7,11 @@ concurrency:
 on:
   pull_request:
     paths:
+      - "examples/todos/pubspec.yaml"
       - "examples/todos/routes/**"
       - "examples/todos/lib/**"
       - "examples/todos/test/**"
+      - "examples/todos/packages/**/pubspec.yaml"
       - "examples/todos/packages/**/lib/**"
       - "examples/todos/packages/**/test/**"
       - "examples/todos/packages/**/e2e/**"

diff --git a/.github/workflows/examples_web_socket_counter.yaml b/.github/workflows/examples_web_socket_counter.yaml
@@ -7,6 +7,7 @@ concurrency:
 on:
   pull_request:
     paths:
+      - "examples/web_socket_counter/pubspec.yaml"
       - "examples/web_socket_counter/routes/**"
       - "examples/web_socket_counter/lib/**"
       - "examples/web_socket_counter/test/**"

diff --git a/examples/counter/analysis_options.yaml b/examples/counter/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml
 analyzer:
   exclude:
     - build/**

diff --git a/examples/counter/pubspec.yaml b/examples/counter/pubspec.yaml
@@ -13,4 +13,4 @@ dev_dependencies:
   http: ^0.13.5
   mocktail: ^0.3.0
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0
diff --git a/examples/echo/analysis_options.yaml b/examples/echo/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml
 analyzer:
   exclude:
     - build/**

diff --git a/examples/echo/pubspec.yaml b/examples/echo/pubspec.yaml
@@ -13,4 +13,4 @@ dev_dependencies:
   http: ^0.13.5
   mocktail: ^0.3.0
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0
diff --git a/examples/hello_world/analysis_options.yaml b/examples/hello_world/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml
 analyzer:
   exclude:
     - build/**

diff --git a/examples/hello_world/pubspec.yaml b/examples/hello_world/pubspec.yaml
@@ -13,4 +13,4 @@ dev_dependencies:
   http: ^0.13.5
   mocktail: ^0.3.0
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0
diff --git a/examples/kitchen_sink/analysis_options.yaml b/examples/kitchen_sink/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml
 analyzer:
   exclude:
     - build/**

diff --git a/examples/kitchen_sink/pubspec.yaml b/examples/kitchen_sink/pubspec.yaml
@@ -13,4 +13,4 @@ dev_dependencies:
   http: ^0.13.5
   mocktail: ^0.3.0
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0
diff --git a/examples/todos/analysis_options.yaml b/examples/todos/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml
 analyzer:
   exclude:
     - build/**

diff --git a/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml b/examples/todos/packages/in_memory_todos_data_source/analysis_options.yaml
@@ -1 +1 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml
diff --git a/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml b/examples/todos/packages/in_memory_todos_data_source/pubspec.yaml
@@ -4,7 +4,7 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
+  sdk: ">=2.19.0 <3.0.0"
 
 dependencies:
   todos_data_source:
@@ -14,4 +14,4 @@ dependencies:
 dev_dependencies:
   mocktail: ^0.3.0
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0
diff --git a/examples/todos/packages/todos_data_source/analysis_options.yaml b/examples/todos/packages/todos_data_source/analysis_options.yaml
@@ -1 +1 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml
diff --git a/examples/todos/packages/todos_data_source/lib/src/models/todo.dart b/examples/todos/packages/todos_data_source/lib/src/models/todo.dart
@@ -22,8 +22,8 @@ part 'todo.g.dart';
 class Todo extends Equatable {
   /// {@macro `todo`}
   Todo({
-    this.id,
     required this.title,
+    this.id,
     this.description = '',
     this.isCompleted = false,
   }) : assert(id == null || id.isNotEmpty, 'id cannot be empty');

diff --git a/examples/todos/packages/todos_data_source/pubspec.yaml b/examples/todos/packages/todos_data_source/pubspec.yaml
@@ -4,7 +4,7 @@ version: 0.1.0+1
 publish_to: none
 
 environment:
-  sdk: ">=2.17.0 <3.0.0"
+  sdk: ">=2.19.0 <3.0.0"
 
 dependencies:
   equatable: ^2.0.3
@@ -16,4 +16,4 @@ dev_dependencies:
   json_serializable: ^6.3.1
   mocktail: ^0.3.0
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0
diff --git a/examples/todos/pubspec.yaml b/examples/todos/pubspec.yaml
@@ -17,4 +17,4 @@ dev_dependencies:
   http: ^0.13.5
   mocktail: ^0.3.0
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0
diff --git a/examples/web_socket_counter/analysis_options.yaml b/examples/web_socket_counter/analysis_options.yaml
@@ -1,4 +1,4 @@
-include: package:very_good_analysis/analysis_options.3.1.0.yaml
+include: package:very_good_analysis/analysis_options.4.0.0.yaml
 analyzer:
   exclude:
     - build/**

diff --git a/examples/web_socket_counter/pubspec.yaml b/examples/web_socket_counter/pubspec.yaml
@@ -16,5 +16,5 @@ dev_dependencies:
   http: ^0.13.5
   mocktail: ^0.3.0
   test: ^1.19.2
-  very_good_analysis: ^3.1.0
+  very_good_analysis: ^4.0.0
   web_socket_client: ^0.1.0-dev.1