Fix versions for flask and flask_cors #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the "allows headers" list is now case sensitive so have raised an issue with Flask CORS. See corydolphin/flask-cors#187 |
mblancodev
pushed a commit
to edgeuno/alerta
that referenced
this pull request
Oct 18, 2022
Fix clearing of searchbox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something changed from 2.1.3 -> 3.0.0 but I can't work out why it breaks CORS for Alerta server. So for now this will fix the Flask CORS package version to 2.1.3 until I can work out what's changed. See https://github.com/corydolphin/flask-cors/blob/master/CHANGELOG.md#300
Should fix alerta/angular-alerta-webui#62