Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correct line number for json example #265

Merged
merged 2 commits into from Jan 24, 2022
Merged

fix: correct line number for json example #265

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8d95a5
fix: correct line number for json example
leon332157 Jan 24, 2022
2aa0d1c
revert accidental change on line 395
leon332157 Jan 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.md
View file
Open in desktop
Expand Up @@ -392,7 +392,7 @@ Kong support a nested data structure as well with `embed:""`. You can combine `e
var CLI struct {
Logging struct {
Level string `enum:"debug,info,warn,error" default:"info"`
Type string `enum:"json,console" default:"console"`
Type string `enum:"https://github.com/alecthomas/kong/blob/3987efba8647711f11290d443e07106f22f7393f/resolver_test.go#L206,console" default:"console"`
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't intend that change. I only intended to change line 586, sorry.

} `embed:"" prefix:"logging."`
}
```
Expand Down Expand Up @@ -583,7 +583,7 @@ eg.
kong.Parse(&cli, kong.Configuration(kong.JSON, "/etc/myapp.json", "~/.myapp.json"))
```

[See the tests](https://github.com/alecthomas/kong/blob/master/resolver_test.go#L103) for an example of how the JSON file is structured.
[See the tests](https://github.com/alecthomas/kong/blob/master/resolver_test.go#L206) for an example of how the JSON file is structured.

### `Resolver(...)` - support for default values from external sources

Expand Down