Add support for Rego syntax #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adapted heavily from several of the lexers in this repo, and https://github.com/tsandall/vim-rego/blob/b47bf95996b72d630464b44ca567f2945bd37ac9/syntax/rego.vim
jamietanna
force-pushed
the
feature/rego
branch
from
6aefb9b
to
8fba410
Compare
|
Argh sorry @alecthomas it looks like this hasn't actually worked OK - it looks like some of the text doesn't get recognised correctly.
Any hints as what best to do here? Happy to revert this PR until we've fixed it! |
|
No worries I'd add a test and iterate until it passes |
|
Interesting, thanks - will give that a go tomorrow! Will also update the README to add |
|
FYI you can also use the chroma CLI to manually test your lexer: |
|
Thanks I had actually been doing that 🫣 but I changed themes to improve the output, but should have gone back to the default so I knew I'd not finished it off |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted heavily from several of the lexers in this repo, and
https://github.com/tsandall/vim-rego/blob/b47bf95996b72d630464b44ca567f2945bd37ac9/syntax/rego.vim