Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: update nord theme to have a base color for NameProperty #787

Merged
merged 1 commit into from May 1, 2023

Conversation

CoolGoose
Copy link
Contributor

Right now there is no value for NameProperty making .chroma .py to be empty.

Because of that there are cases in which the color is wrongly used because it's not overwritten (for eg: when trying to use a light theme as the main one, and Nord under prefers-color-scheme: dark .

This sets the color to match the one from the theme preview that is applied for the methods

Before:
image
After:
image

Right now there is no value for NameProperty making .chroma .py to be empty.

Because of that there are cases in which the color is wrongly used because it's not overwritten (for eg: when trying to use a light theme as the main one, and Nord under prefers-color-scheme: dark .

This sets the color to match the one from the theme preview that is applied for the methods
@alecthomas alecthomas merged commit bf8d359 into alecthomas:master May 1, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants