Skip to content

Commit

Permalink
fix: dependency flag not recognized (jaegertracing#3724)
Browse files Browse the repository at this point in the history
Signed-off-by: Benedikt Bongartz <bongartz@klimlive.de>

Co-authored-by: Yuri Shkuro <yurishkuro@users.noreply.github.com>
Signed-off-by: Albert Teoh <see.kwang.teoh@gmail.com>
  • Loading branch information
2 people authored and albertteoh committed Jul 13, 2022
1 parent a378256 commit 07251f6
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions cmd/es-rollover/app/flags.go
Expand Up @@ -69,4 +69,5 @@ func (c *Config) InitFromViper(v *viper.Viper) {
c.ILMPolicyName = v.GetString(ilmPolicyName)
c.UseILM = v.GetBool(useILM)
c.Timeout = v.GetInt(timeout)
c.SkipDependencies = v.GetBool(skipDependencies)
}
2 changes: 2 additions & 0 deletions cmd/es-rollover/app/flags_test.go
Expand Up @@ -41,6 +41,7 @@ func TestBindFlags(t *testing.T) {
"--es.password=qwerty123",
"--es.use-ilm=true",
"--es.ilm-policy-name=jaeger-ilm",
"--skip-dependencies=true",
})
require.NoError(t, err)

Expand All @@ -51,4 +52,5 @@ func TestBindFlags(t *testing.T) {
assert.Equal(t, "admin", c.Username)
assert.Equal(t, "qwerty123", c.Password)
assert.Equal(t, "jaeger-ilm", c.ILMPolicyName)
assert.Equal(t, true, c.SkipDependencies)
}

0 comments on commit 07251f6

Please sign in to comment.