Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installed CDS with overrides #25

Merged
merged 40 commits into from
Apr 2, 2023
Merged

Conversation

albert118
Copy link
Owner

@albert118 albert118 commented Apr 1, 2023

Changes

  • moved to Carbon Design System (aka. CBS in commit messages)
    • still supports react v17 (override allows installation as-is)

edit: I've somehow typo'd all of the commits in this repo for 'CDS' as 'CBS'

Discussion and Override

See here for the v18 support, hack, and ongoing discussion

Found this discussion about CBS from Open Edx

@albert118
Copy link
Owner Author

Renders

image

image

@albert118 albert118 added frontend UI Changes (JS, CSS, etc.) housekeeping editor settings, .gitIgnore, README.md, etc. and removed housekeeping editor settings, .gitIgnore, README.md, etc. labels Apr 2, 2023
@albert118 albert118 marked this pull request as ready for review April 2, 2023 06:30
@albert118 albert118 merged commit d8a7ea3 into master Apr 2, 2023
@albert118 albert118 deleted the feature/carbon-design-system branch April 2, 2023 06:30
@albert118
Copy link
Owner Author

side effect of this was the sidebar animation improving through better layout

@albert118 albert118 mentioned this pull request Apr 2, 2023
@albert118 albert118 changed the title installed CBS with overrides installed CDS with overrides Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend UI Changes (JS, CSS, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant