Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the AVM to the latest version of tokio #370

Merged
merged 7 commits into from Jan 6, 2021
Merged

Conversation

cdmistman
Copy link
Collaborator

Fixes #369

@CLAassistant
Copy link

CLAassistant commented Jan 4, 2021

CLA assistant check
All committers have signed the CLA.

avm/src/vm/opcode.rs Outdated Show resolved Hide resolved
avm/src/vm/opcode.rs Outdated Show resolved Hide resolved
@cdmistman cdmistman changed the title [WIP] Upgrade the AVM to the latest version of tokio Upgrade the AVM to the latest version of tokio Jan 5, 2021
@cdmistman cdmistman requested a review from a team January 5, 2021 19:31
@cdmistman cdmistman changed the title Upgrade the AVM to the latest version of tokio [WIP] Upgrade the AVM to the latest version of tokio Jan 5, 2021
@cdmistman
Copy link
Collaborator Author

forgot about actually upgrading to tokio 1, next commit should finish this PR

@cdmistman cdmistman changed the title [WIP] Upgrade the AVM to the latest version of tokio Upgrade the AVM to the latest version of tokio Jan 5, 2021
@cdmistman cdmistman requested a review from dfellis January 5, 2021 19:42
@cdmistman
Copy link
Collaborator Author

cdmistman commented Jan 5, 2021

MacOS CI (and local build) fails because mio:0.7.7 is using libc:0.2.69, whereas libc:0.2.71 is the minimum required version to use libc::TCP_KEEP_INTVL and libc::TCP_CNT (introduced in this PR). See tokio-rs/mio#1433 for more info. Blocked on tokio-rs/mio#1434 merge, mio:0.7.8, and all mio-based dependencies converging on the updated crate.

@dfellis
Copy link
Member

dfellis commented Jan 5, 2021

and all mio-based dependencies converging on the updated crate.

Is it not possible to override the dependencies of other dependencies in Rust? Worst-case by hand-editing Cargo.lock? I though that's what that file was for.

avm/src/vm/opcode.rs Outdated Show resolved Hide resolved
@cdmistman cdmistman merged commit d3f5239 into main Jan 6, 2021
@cdmistman cdmistman deleted the 369_upgrade_tokio branch January 6, 2021 02:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade the AVM to the latest version of tokio
4 participants