Migrate from winapi to windows-sys #6364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisduerr
requested changes
Sep 26, 2022
kchibisov
previously requested changes
Sep 28, 2022
added 2 commits
September 29, 2022 12:03
|
Yes, after checking, winit uses version 0.36 for windows-sys so I configured it the same way. |
killianc3
requested review from
kchibisov and
chrisduerr
and removed request for
kchibisov and
chrisduerr
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After seeing this issue #5993 and because winapi is not maintained, i think migrating to windows-sys is a good thing, what do you think ?