Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issue #5669 #5747

Closed
wants to merge 0 commits into from
Closed

fix: issue #5669 #5747

wants to merge 0 commits into from

Conversation

wendajiang
Copy link
Contributor

update Cargo.lock
dep winit version update to release 0.26.1

close #5669

kchibisov
kchibisov requested changes Jan 5, 2022
View reviewed changes
Copy link
Member

@kchibisov kchibisov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you bump only winit, since this commit will be cherry picked later on v0.10.0 branch and clap update shouldn't go there? Thanks.

cargo update -p winit

@chrisduerr
Copy link
Member

Could you bump only winit, since this commit will be cherry picked later on v0.10.0 branch and clap update shouldn't go there? Thanks.

We'll likely have to bump the Cargo.lock separately just for the sake of simplicity on rebase, but this patch should still only make the minimal Cargo.lock changes necessary.

@wendajiang wendajiang closed this Jan 6, 2022
@wendajiang
Copy link
Contributor Author

I open a new PR #5749 to bump only winit version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kchibisov kchibisov kchibisov requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.10.0 dev (master branch) can not input chinese by apple input method
3 participants
@wendajiang @chrisduerr @kchibisov