0.10.0 dev (master branch) can not input chinese by apple input method

[wendajiang]

System

OS: macOS (m1 pro silicon)
Version: 0.10.0 dev

problem：

press 1 to choose 你好, but alacritty show ni hao

[wendajiang]

eg.
release 0.9.0 build on m1 macbook, can input chinese, but press delete can delete alacritty character not only input method pinyin

[chrisduerr]

Can you bisect which commit introduced this regression? I'd probably start with 4c6a763.

[wendajiang]

Yes, I try to back to 8681f71, representation is equal release 0.9.0

[chrisduerr]

Yes, I try to back to 8681f71, representation is equal release 0.9.0

Are you claiming 8681f71 broke it? Because that's difficult to believe.

[wendajiang]

No, I also think it start with 4c6a763 😂

[chrisduerr]

You think? Are you guessing or have you actually confirmed it?

[wendajiang]

back

As I say, I try to git reset 8681f71, and the input is equal to release 0.9.0, and reset 4c6a763, it doesn't work.

[ArturKovacs]

I have a suspicion that @wendajiang has an incorrect idea of what the expected behavior is.

@wendajiang please do the following steps in Alacritty

1. type "ni hao"
2. press 1
3. press return

Does Alacritty show 你好 instead of ni hao? Because that's the intended behavior as far as I understand.

[chrisduerr]

@ArturKovacs has the behavior changed? Or was it supposed to? Seems like there certainly seems to be a difference.

[ArturKovacs]

Yes, it was supposed to change. Although due to my mistake it wasn't noted in winit's changelog.

This is the PR that changed the behavior: rust-windowing/winit#1979

[wendajiang]

I have a suspicion that @wendajiang has an incorrect idea of what the expected behavior is.

@wendajiang please do the following steps in Alacritty

1. type "ni hao"
2. press 1
3. press return

Does Alacritty show 你好 instead of ni hao? Because that's the intended behavior as far as I understand.

Unfortunately, when I do these steps, Alacrity still show ni hao, as when press 1, the input is already end, then press return, terminal see ni hao as command

[ArturKovacs]

Thank you for checking.

I made a PR for winit that reverts the changes that caused this issue. rust-windowing/winit#2119

[chrisduerr]

@ArturKovacs Do you plan on releasing a new patch version? Would love to ensure Alacritty's 0.10.0 doesn't introduce a regression.

[ArturKovacs]

Do you plan on releasing a new patch version?

Good idea, I'll pursue a quick release.

[ArturKovacs]

The new winit version, 0.26.1 has been released with the fix

[chrisduerr]

Fixed in 50c7c2b.