Explore fix for chart spacing #440

ifirmawan · 2023-11-20T07:31:26Z

TODO/DONE

Use instance wai-uganda
Import household data from cleaned data/WAI_Uganda_baseline_household_CLEANED (1).xlsx]
Go to JMP Households
Filter JMP chart by district: Agago, sub-county: Lira Palwo
You will get something like this

To see the specific tasks where the Asana app for GitHub is being used, see below:
- https://app.asana.com/0/0/1205975646364885

coveralls · 2023-11-20T07:38:13Z

coverage: 79.514%. remained the same
when pulling 7fbd5b6 on feature/432-show-empty-value-for-jmp-charts-bug
into 14f843e on sandbox.

dedenbangkit

Your changes makes the space too high for the JMP charts

ifirmawan added 4 commits November 20, 2023 14:14

[#432] Remove unnecessary height in TabJMP

d506e0f

[#412] Set default 0 for percentage value

aea5b23

[#432] Replace chartData w/ filteredChartData based on empty filtering

969ad17

[#432] Fix chart spacing by adding grid height

a17fcb2

ifirmawan self-assigned this Nov 20, 2023

[#432] Fix StackBar & TabJMP test by removing height

32a80a3

[#432] Fix split bar overlapping when filter is active

6d17b9b

ifirmawan marked this pull request as draft November 20, 2023 07:49

ifirmawan added 3 commits November 20, 2023 14:53

[#412] Fix JMP BarStack yAxis labels are being cut off

29bbc41

[#432] Increase stacked bar chart height

1e818ca

[#432] Set JMP bar stack height to 120 for one data

7fbd5b6

ifirmawan requested a review from dedenbangkit November 20, 2023 08:16

ifirmawan marked this pull request as ready for review November 20, 2023 08:16

ifirmawan linked an issue Nov 21, 2023 that may be closed by this pull request

Add show empty value for JMP Charts #432

Open

dedenbangkit requested changes Dec 1, 2023

View reviewed changes